Strange behaviour during translations

[Jordi Sanfeliu]

Hi,

I'm ready to send the Spanish and Catalan translations to the mail that appears in the Development Guide (translations@intermesh.nl), but before do that I want to share a very strange behaviour in two variable definitions in one ca.inc file (for the Catalan language).

$ml_loose_changes and $ml_please_close_attachments seems does not even accept escape the single quote like this:

"aaaa bbbb\'bb ccc";

At this moment the only workaround has been to rethink the phrase to try to not include a single quote. :-/

Can you confirm that situation before I send the language packages?

[Intermesh]

If the string is encapsulated by 2 double qoutes then you shouldn't escape the single quotes. Two examples:

"It wasn't me"
'It wasn\'t me'

Both should work fine. I prefer you use the second style.

[Jordi Sanfeliu]

I noticed that, my example is incorrect, the string is encapsulated by 2 single quotes like this:

'It wasn\'t me'

If I simply remove the escaped single quote and leave the string like:

'It wasnt me'

it works!!

Where is the problem?

PS: The complete file path is:
/modules/email/language/ca.inc

[Intermesh]

Is the file encoded in UTF-8 encoding?

[Jordi Sanfeliu]

Every time I started a file translations it has been copied from the original english version "en.inc", and VIM does not notify any conversion, and even the option "fileenconding" is set to utf-8.

Can you see in the code if those two variable have a special treatment that can generate some bug?

[Jordi Sanfeliu]

TIP!

Lot of other strings in the same ca.inc file and others have a single quote in and does not create any problem.

How I have discovered this strange behaviour?

If the two above mentioned variables contains a single quote in, the button called "Attachments" that appears in the window when you are creating a new email does not open any browsing dialog window.

On the other hand, if you removes the single quote from the mentioned strings, the button opens the expected brower dialog window.

:-/

[Intermesh]

I forgot to encode the strings for the javascript functions. Please look up the values in modules/email/compose.inc and change them to:

htmlspecialchars(addslashes($ml_please_close_attachments))
htmlspecialchars(addslashes($ml_loose_changes))

[Jordi Sanfeliu]

Ok, all is fixed now. Case closed

Right now I will send the two translation packages (Spanish and Catalan).

Thanks for your support.